RFR: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F [v2]

[Tejesh R]

On Thu, 22 Aug 2024 00:01:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Updated review comments
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8338041
>>  - Test updates
>>  - Key action modified + Automatic test added
>
> test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java line 124:
> 
>> 122:             String failureMsg = "Test Failure. Failed to select cells for Ctrl" +
>> 123:                     " Shift " + key + " selection";
>> 124:             throw new RuntimeException(failureMsg);
> 
> Suggestion: A StringBuffer can be used to log the errors and the RuntimeException can be thrown at the end after checking both cases- left and right selection similar to this test https://github.com/openjdk/jdk/blob/47c8a6a8db979fe862be876008feb76cdc9dccfd/test/jdk/javax/swing/plaf/metal/MetalBorders/ScaledMetalBorderTest.java#L82

Noted, StringBuffer can be used to log errors. But I don't think it's required here since we are not appending anything to Error message and also when either of selection fails its better to throw exception without proceeding to other side of test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1726359461