RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F

Alexey Ivanov aivanov at openjdk.org
Fri Aug 23 08:59:04 UTC 2024


On Thu, 22 Aug 2024 05:24:24 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> This test should have failed with the [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't because GTK look and feel isn't supported in headless environment.
> 
> Fix is to run the test with headful environment on linux platform. 
> 
> Tested in CI pipeline and link attached to JBS.

Please, update the copyright year.

test/jdk/javax/swing/JFileChooser/8080628/bug8080628.java line 105:

> 103:         }
> 104:     }
> 105: 

I'd rather keep this blank line. Most classes have blank line between the closing brace of the last method and the closing brace of the class itself.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20671#pullrequestreview-2256726122
PR Review Comment: https://git.openjdk.org/jdk/pull/20671#discussion_r1728627065


More information about the client-libs-dev mailing list