RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F

Abhishek Kumar abhiscxk at openjdk.org
Fri Aug 23 09:28:22 UTC 2024


On Fri, 23 Aug 2024 08:59:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > @kumarabhi006
> > > Fix is to run the test with headful environment on linux platform.
> > 
> > 
> > Does this have to do with not loading the gtk files in headless mode? https://github.com/openjdk/jdk/blob/master/src/java.desktop/unix/native/libawt_xawt/awt/gtk_interface.c#L26C1-L28C7
> 
> Yes, that's exactly the problem.
> 
> Abhishek and I discussed !20612, and I expected this test to fail with the changes on the review but it didn't.

Yes, since this file is not included in headless environment, related gtk libraries are not loaded. @honkar-jdk Thanks for pointing it out.

@aivanov-jdk Please re-review again. Due to recent changes, it is required to review the latest commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20671#issuecomment-2306674817
PR Comment: https://git.openjdk.org/jdk/pull/20671#issuecomment-2306677974


More information about the client-libs-dev mailing list