RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v4]

Phil Race prr at openjdk.org
Fri Aug 23 18:39:04 UTC 2024


On Thu, 22 Aug 2024 18:04:46 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This PR creates a new test by stabilising and open sourcing a closed test.
>> This test verifies that the OpenGL pipeline does not create artifacts with swing components after window is zoomed to maximum size and then resized back to normal.
>> This test is run twice, with and without the flags "-Dsun.java2d.opengl=True -Dsun.java2d.opengl.fbobject=false" .
>> 
>> This is tested(15 times per platform) in all the available mach5 headful platforms and found to be stable.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fixed : Changed the position of line comments

test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 54:

> 52:  * a JButton.  A file image of the component will be saved before and after
> 53:  * window resize. The test passes if both button images are the same.
> 54:  * @run main/othervm -Dsun.java2d.opengl=True -Dsun.java2d.opengl.fbobject=false SwingButtonResizeTestWithOpenGL

Does this really work well on Windows ?  Commonly OpenGL tests fail on Windows.
Did you test it there ?

Also is there any reason we can't test this with additional pipelines on specific platforms ?
The behaviours being tested are Java behaviours so it ought to pass in other cases too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20532#discussion_r1729377430


More information about the client-libs-dev mailing list