RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v4]
Manukumar V S
mvs at openjdk.org
Fri Aug 23 18:53:10 UTC 2024
On Fri, 23 Aug 2024 18:36:40 GMT, Phil Race <prr at openjdk.org> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment fixed : Changed the position of line comments
>
> test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 54:
>
>> 52: * a JButton. A file image of the component will be saved before and after
>> 53: * window resize. The test passes if both button images are the same.
>> 54: * @run main/othervm -Dsun.java2d.opengl=True -Dsun.java2d.opengl.fbobject=false SwingButtonResizeTestWithOpenGL
>
> Does this really work well on Windows ? Commonly OpenGL tests fail on Windows.
> Ah I see in the bug report you say you tested on all platforms OK.
>
> Also is there any reason we can't test this with additional pipelines on specific platforms ?
> The behaviours being tested are Java behaviours so it ought to pass in other cases too.
Yes, I tested it on different windows platforms (Windows 10,11,2022) and it succeeded everywhere.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20532#discussion_r1729391151
More information about the client-libs-dev
mailing list