RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v7]

Manukumar V S mvs at openjdk.org
Wed Aug 28 09:22:22 UTC 2024


On Wed, 28 Aug 2024 09:06:23 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments fixed : Sorted imports, formatting changes, saving images only on failure, compare changed, dispose on EDT
>
> test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 187:
> 
>> 185:             Point buttonLoc = buttonLocRef.get();
>> 186:             System.out.println("Button loc: " + buttonLoc);
>> 187:             bimage = robot.createScreenCapture(new Rectangle(buttonLoc.x, buttonLoc.y, button.getWidth(), button.getHeight()));
> 
> Can we return the capturedScreen directly? I guess **yes** and then BufferedImage object is not required and can be removed.

The screen captured BufferedImage(bimage) is directly returned now, do you want to change it ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20532#discussion_r1734315191


More information about the client-libs-dev mailing list