RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v7]

Manukumar V S mvs at openjdk.org
Wed Aug 28 09:31:21 UTC 2024


On Wed, 28 Aug 2024 09:19:51 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 187:
>> 
>>> 185:             Point buttonLoc = buttonLocRef.get();
>>> 186:             System.out.println("Button loc: " + buttonLoc);
>>> 187:             bimage = robot.createScreenCapture(new Rectangle(buttonLoc.x, buttonLoc.y, button.getWidth(), button.getHeight()));
>> 
>> Can we return the capturedScreen directly? I guess **yes** and then BufferedImage object is not required and can be removed.
>
> The screen captured BufferedImage(bimage) is directly returned now, do you want to change it ?

Ohh you are talking about the BufferedImage object, yes it is needed as the screen capture is inside a try block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20532#discussion_r1734328708


More information about the client-libs-dev mailing list