RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v2]

Manukumar V S mvs at openjdk.org
Sat Aug 31 09:08:59 UTC 2024


> This is a highly intermittent failure, and it failed only once in CI on a particular windows machine and passed on all other runs. 
> 
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn on the button text(Button A) was not seen(failure images attached in the bug).
> 
> Fix:
> To stabilize the test, I have added a line -> button.setFocusPainted(false), so that the focus rectangle will not be painted

Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:

  Review Comments Fixed : Further stabilized the test by increasing the delay as well as removing some unwanted lines of code

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20777/files
  - new: https://git.openjdk.org/jdk/pull/20777/files/58979a38..3e8e35a6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20777&range=00-01

  Stats: 8 lines in 1 file changed: 0 ins; 6 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/20777.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20777/head:pull/20777

PR: https://git.openjdk.org/jdk/pull/20777


More information about the client-libs-dev mailing list