RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v2]

Manukumar V S mvs at openjdk.org
Sat Aug 31 09:12:23 UTC 2024


On Sat, 31 Aug 2024 00:30:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Since the following are on unchanged lines, I'm including it as a consolidated note:
> 
> 1. robot.setAutoWaitForIdle(true);
>    robot.setAutoDelay(200);
>    doesn't change anything as there are no robot mouse or key events so it can be removed.
> 2. Individual `robot.delay()` can be added after UI creation and when frame state is changed to stabilize the test.
> 3. Frame is assigned null after disposing which is not required and can be removed.
> 
> ```
>     private void disposeFrame() {
>         if (frame != null) {
>             frame.dispose();
>             frame = null;
>         }
>     }
> ```

Fixed all these.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2322837108


More information about the client-libs-dev mailing list