RFR: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI [v5]

Jeremy duke at openjdk.org
Sun Dec 8 07:52:17 UTC 2024


On Thu, 5 Dec 2024 13:22:01 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Jeremy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8342782: expanding wildcard imports
>>   
>>   This is in response to:
>>   https://github.com/openjdk/jdk/pull/21962#discussion_r1857389973
>
> src/java.desktop/share/classes/java/awt/AWTEventMulticaster.java line 1020:
> 
>> 1018:             return new AWTEventMulticaster(array[index0], array[index1]);
>> 1019:         }
>> 1020:         int mid = (index0 + index1)/2;
> 
> Suggestion:
> 
>         int mid = (index0 + index1) / 2;

OK; this is updated

> test/jdk/java/awt/event/StressTest/LargeAWTEventMulticasterTest.java line 96:
> 
>> 94:         }
>> 95:     }
>> 96: }
> 
> Please add an empty line representing EOF.

OK; this is updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21962#discussion_r1874638586
PR Review Comment: https://git.openjdk.org/jdk/pull/21962#discussion_r1874638707


More information about the client-libs-dev mailing list