RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v2]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Thu Feb 1 07:14:02 UTC 2024
On Wed, 31 Jan 2024 21:51:16 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Capitalized static final variables
>
> test/jdk/java/awt/print/PrinterJob/DrawStringMethods.java line 70:
>
>> 68: .build();
>> 69:
>> 70: PrinterJob pjob = PrinterJob.getPrinterJob();
>
> i think this could be moved into a helper function and called by passFailJFrame builder via .testui(DrawStringMethods::helperFunction)
These class do not have any UI/frame, so I don't think it will workout here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1473892594
More information about the client-libs-dev
mailing list