RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v2]

Alexey Ivanov aivanov at openjdk.org
Wed Feb 7 20:32:02 UTC 2024


On Thu, 1 Feb 2024 07:09:55 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/DrawStringMethods.java line 70:
>> 
>>> 68:                 .build();
>>> 69: 
>>> 70:         PrinterJob pjob = PrinterJob.getPrinterJob();
>> 
>> i think this could be moved into a helper function and called by passFailJFrame builder via .testui(DrawStringMethods::helperFunction)
>
> These class do not have any UI/frame, so I don't think it will workout here.

Right, `PassFailJFrame` works correctly without secondary test UI. There's not requirement to create test UI if it's not needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1482011936


More information about the client-libs-dev mailing list