Integrated: 6507038: Memory Leak in JTree / BasicTreeUI

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Feb 8 11:58:09 UTC 2024


On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> When using a TreeCellRenterer which creates new components in getTreeCellRendererComponent() in a JTree that is not visible, changes to the nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is called to calculate the new dimensions for the node. In this method, getTreeCellRendererComponent() is called to obtain the renderer component (what else...) and [this component is added to rendererPane](https://github.com/openjdk/jdk/blob/36f4b34f1953af736706ec67192204727808bc6c/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java#L3283-L3284). It is not removed from the rendererPane afterwards. 
> Only when the tree is painted, the paint() method does a removeAll on the rendererPane [in this code](https://github.com/openjdk/jdk/blob/36f4b34f1953af736706ec67192204727808bc6c/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java#L1500)
> 
> FIx is added to remove the components from rendererPane when the JTree UI is changed/uninstalled only when tree is not visible since they are already removed when tree is painted in paint() method..

This pull request has now been integrated.

Changeset: e8ceb718
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e8ceb7189be79f2a5a7a4d13fe2d93e2c494abce
Stats:     226 lines in 2 files changed: 224 ins; 0 del; 2 mod

6507038: Memory Leak in JTree / BasicTreeUI

Co-authored-by: Alexey Ivanov <aivanov at openjdk.org>
Reviewed-by: honkar, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/17458


More information about the client-libs-dev mailing list