RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v4]

Renjith Kannath Pariyangad rkannathpari at openjdk.org
Fri Feb 9 09:43:05 UTC 2024


On Thu, 8 Feb 2024 12:03:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments integrated
>
> test/jdk/java/awt/print/PrinterJob/DrawImage.java line 131:
> 
>> 129:         Graphics2D g2D = (Graphics2D) result.getGraphics();
>> 130:         g2D.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
>> 131:                 RenderingHints.VALUE_ANTIALIAS_OFF);
> 
> This hasn't been agreed upon (yet).
> 
> I prefer the style where the wrapped parameters are aligned to the start of the expression. That is the way it was before. Generally, I'd avoid modifying lines you don't change.
> 
> What do other reviewers think?

Used IDE alignment for conveniences, its a side effect of that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1484081884


More information about the client-libs-dev mailing list