RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

Alexey Ivanov aivanov at openjdk.org
Wed Feb 14 14:13:06 UTC 2024


On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a single *Print* button as its test UI. To simplify the UI, I used the new `splitUI` method from #17845.
>> 
>> In addition to it, I refactored the test:
>> 
>> - Extracted the rendered text into a constant to ensure the same text is printed and displayed in the instructions.
>> - Displayed an error message to the tester if `PrinterException` is caught and automatically failed the test.
>
> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge 8294148-splitUI
>  - Revert the condition in print()
>  - Update copyright year
>  - Handle PrinterException
>  - Ensure the same text is printed and displayed in the instructions
>  - 8325762: Use split UI for PrintLatinCJKTest

The updated test UI looks like this:

![Screenshot of PrintLatinCJKTest with the default split UI to the right: instructions and Pass/Fail buttons on the left, Print button of test UI on the right](https://github.com/openjdk/jdk/assets/70774172/502372c1-dfa4-4c8d-a23d-36996151859b)

If you use `splitUIBottom`, the *Print* button is displayed below the instructions:  
![Screenshot of PrintLatinCJKTest with the vertical split UI: instructions and Pass/Fail buttons on the top, Print button of test UI on the bottom](https://github.com/openjdk/jdk/assets/70774172/8f5047aa-7a40-49c2-ab56-9dc8004203c0)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17847#issuecomment-1943843228


More information about the client-libs-dev mailing list