RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

Harshitha Onkar honkar at openjdk.org
Wed Feb 14 22:16:03 UTC 2024


On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a single *Print* button as its test UI. To simplify the UI, I used the new `splitUI` method from #17845.
>> 
>> In addition to it, I refactored the test:
>> 
>> - Extracted the rendered text into a constant to ensure the same text is printed and displayed in the instructions.
>> - Displayed an error message to the tester if `PrinterException` is caught and automatically failed the test.
>
> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge 8294148-splitUI
>  - Revert the condition in print()
>  - Update copyright year
>  - Handle PrinterException
>  - Ensure the same text is printed and displayed in the instructions
>  - 8325762: Use split UI for PrintLatinCJKTest

@aivanov-jdk Changes related to new implementation of PassFailJFrame -splitUI looks good. I have a printer configured but I'm running into `PrinterException: Access is denied.` The option of saving to pdf doesn't work too.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17847#pullrequestreview-1881404658


More information about the client-libs-dev mailing list