RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Feb 16 06:48:55 UTC 2024


On Fri, 9 Feb 2024 13:19:19 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg tag headful removed

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 188:

> 186:                 && (state & SynthConstants.ENABLED) != 0) {
> 187:             Color c = (Color) get(context, "Label.foreground");
> 188:             if (c != null) {

Why is it different for Label..We can have foreground color for RadioButton, Checkboxes similar to [JDK-8298083](https://bugs.openjdk.org/browse/JDK-8298083) and there it was not needed..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1492021087


More information about the client-libs-dev mailing list