RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v2]

Abhishek Kumar abhiscxk at openjdk.org
Fri Feb 16 09:18:55 UTC 2024


On Fri, 16 Feb 2024 06:46:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jtreg tag headful removed
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 188:
> 
>> 186:                 && (state & SynthConstants.ENABLED) != 0) {
>> 187:             Color c = (Color) get(context, "Label.foreground");
>> 188:             if (c != null) {
> 
> Why is it different for Label..We can have foreground color for RadioButton, Checkboxes similar to [JDK-8298083](https://bugs.openjdk.org/browse/JDK-8298083) and there it was not needed..

I will check and revert back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1492173975


More information about the client-libs-dev mailing list