RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v2]

Abhishek Kumar abhiscxk at openjdk.org
Fri Feb 16 09:52:56 UTC 2024


On Fri, 16 Feb 2024 09:15:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 188:
>> 
>>> 186:                 && (state & SynthConstants.ENABLED) != 0) {
>>> 187:             Color c = (Color) get(context, "Label.foreground");
>>> 188:             if (c != null) {
>> 
>> Why is it different for Label..We can have foreground color for RadioButton, Checkboxes similar to [JDK-8298083](https://bugs.openjdk.org/browse/JDK-8298083) and there it was not needed..
>
> I will check and revert back.

test bug4314194 mentioned in [JDK-8298083](https://bugs.openjdk.org/browse/JDK-8298083) fails in GTK LAF and rightly it is problemlisted for linux machine. @mrserb has created a bug [JDK-8298153](https://bugs.openjdk.org/browse/JDK-8298153).

So, I think we need to check if color is set by user explicitly in GTK LAF.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1492214907


More information about the client-libs-dev mailing list