RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Feb 20 10:13:54 UTC 2024


On Tue, 20 Feb 2024 06:56:06 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge 8294148-splitUI
>>  - Revert the condition in print()
>>  - Update copyright year
>>  - Handle PrinterException
>>  - Ensure the same text is printed and displayed in the instructions
>>  - 8325762: Use split UI for PrintLatinCJKTest
>
> test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 53:
> 
>> 51: 
>> 52:     private static final String INFO = """
>> 53:             You need a printer for this test. If you have none, let
> 
> Can we use `PrinterJob.lookupPrintServices().length` to check for printer availability?

Yes, we can. There's `@key printer` which implies the test is to be run on a system where at least one printer is available.

What do you suggest actually?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17847#discussion_r1495560054


More information about the client-libs-dev mailing list