RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

Tejesh R tr at openjdk.org
Tue Feb 20 10:36:53 UTC 2024


On Tue, 20 Feb 2024 10:11:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 53:
>> 
>>> 51: 
>>> 52:     private static final String INFO = """
>>> 53:             You need a printer for this test. If you have none, let
>> 
>> Can we use `PrinterJob.lookupPrintServices().length` to check for printer availability?
>
> Yes, we can. There's `@key printer` which implies the test is to be run on a system where at least one printer is available.
> 
> What do you suggest actually?

I am thinking whether the printer availability check is required at Instructions? Is it only instruct the user to PASS the test if it printer is unavailable? Should the test be FAILED if printer is not available as it is done in https://github.com/openjdk/jdk/pull/17790 ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17847#discussion_r1495592952


More information about the client-libs-dev mailing list