RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v6]
Sergey Bylokhov
serb at openjdk.org
Thu Jan 4 17:57:23 UTC 2024
On Thu, 4 Jan 2024 17:04:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Your `TestColorSpace` class is a wrapper on top of the actual color space. So you can compare the results of conversion using `TestColorSpace` vs using "actual color space" directly.
>
> @mrserb With your code above, I get `ArrayIndexOutOfBoundsException`.
>
> Do you mean to say there are two additional bugs?
>
> 1. `ArrayIndexOutOfBoundsException` is thrown;
> 2. Even regular ICC_Profile result in unexpected behaviour.
The ArrayIndexOutOfBoundsException is the bug we are working on in this PR. The "unexpected behavior" we get when we use the TestColorSpace instead of direct usage of built-in profiles - it looks like the codepath we updated has some other bug that affects the rendering results.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1442087244
More information about the client-libs-dev
mailing list