RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v6]

[Sergey Bylokhov]

On Thu, 4 Jan 2024 17:54:10 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> @mrserb With your code above, I get `ArrayIndexOutOfBoundsException`.
>> 
>> Do you mean to say there are two additional bugs?
>> 
>> 1. `ArrayIndexOutOfBoundsException` is thrown;
>> 2. Even regular ICC_Profile result in unexpected behaviour.
>
> The ArrayIndexOutOfBoundsException is the bug we are working on in this PR. The "unexpected behavior" we get when we use the TestColorSpace instead of direct usage of built-in profiles - it looks like the codepath we updated has some other bug that affects the rendering results.

>I thought about it… I thought that the filter itself should exercise the code path that's modified but it doesn't seem like it does… I mean creating images with regular ICC profile and using the wrapper TestColorSpace in conversion: new ColorConvertOp(new TestColorSpace(ColorSpace.getInstance(CS_LINEAR_RGB), null); but it didn't work, the test passes without the fix.

It is passed since it blindly checks the difference between src and dst, and since with proper implementation of TestColorSpacewe we always do "some" conversion -> the images are different -> the test passed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1442096879