Integrated: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows

[Philip Race]

I have two concerns with this integrated fix

(1) Not a single developer who works on the client technology approved 
this.
Client devs don't go unilaterally pushing fixes in hotspot without 
someone from hotspot approving.
Even if JDK has no formal way to  verify that, it is really not 
acceptable to have this happen.
And I have raised this before !
https://mail.openjdk.org/pipermail/client-libs-dev/2023-July/014074.html

(2) This fix was proposed before and discussed here
https://mail.openjdk.org/pipermail/client-libs-dev/2021-November/001116.html
where it was requested that it be withdrawn until there is an actual 
understanding of the
reason for the exception which has NEVER been seen in our testing here 
and once understood
rather than suppressing it needs an actual fix and yet here it is again 
in the form previously rejected.

This fix should be backed out. Please send out a PR to do so.

-phil.

On 1/8/24 3:48 AM, Matthias Baesken wrote:
> On Tue, 2 Jan 2024 15:03:12 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>
>> The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and shows on Windows server 2019 the following JNI warning , so the test fails on this Windows version.
>>
>>   stdout: [WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethodV
>> 	at sun.awt.Win32GraphicsEnvironment.initDisplay(java.desktop at 23-internal/Native Method)
>> 	at sun.awt.Win32GraphicsEnvironment.initDisplayWrapper(java.desktop at 23-internal/Win32GraphicsEnvironment.java:95)
>> 	at sun.awt.Win32GraphicsEnvironment.<clinit>(java.desktop at 23-internal/Win32GraphicsEnvironment.java:63)
>> 	at sun.awt.PlatformGraphicsInfo.createGE(java.desktop at 23-internal/PlatformGraphicsInfo.java:34)
>> 	at java.awt.GraphicsEnvironment$LocalGE.createGE(java.desktop at 23-internal/GraphicsEnvironment.java:93)
>> 	at java.awt.GraphicsEnvironment$LocalGE.<clinit>(java.desktop at 23-internal/GraphicsEnvironment.java:84)
>> 	at java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(java.desktop at 23-internal/GraphicsEnvironment.java:106)
>> 	at FreeTypeScalerJNICheck.runTest(FreeTypeScalerJNICheck.java:53)
>> 	at FreeTypeScalerJNICheck.main(FreeTypeScalerJNICheck.java:44)
>>
>>
>> We better add an exception check to get rid of the JNI warning (and also of the test failure) .
> This pull request has now been integrated.
>
> Changeset: 71aac7a5
> Author:    Matthias Baesken <mbaesken at openjdk.org>
> URL:       https://git.openjdk.org/jdk/commit/71aac7a5fbb9a32181ada1a04b6a9622fe939c59
> Stats:     8 lines in 1 file changed: 6 ins; 0 del; 2 mod
>
> 8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows
>
> Reviewed-by: rschmelter, stuefe
>
> -------------
>
> PR: https://git.openjdk.org/jdk/pull/17224