RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

[Sergey Bylokhov]

On Thu, 30 Nov 2023 19:20:50 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi Reviewers, 
>> There was a typo for color conversion instead of dstColorSpace function srcColorSpace was used. Please review and let me know your suggestions if any. 
>> 
>> Renjith.
>
> Can this patch be covered by the new test?

>I'm not sure… We want the filter to take another path, there could be a list of filters applied, if I understand @mrserb correctly. Sergey could be able to provide a more detailed guidance.

The current test validates two code paths:
 - wrapper>icc_color_space->wrapper
 - icc_color_space->icc_color_space->icc_color_space

The color space in the middle is always icc_color_space: https://github.com/openjdk/jdk/pull/16895/files#diff-70b19b2642d6d3f44904de8b6eb2993e1c97320e3476898c4372db364c4288b7R130

If it we cover the wrapper for the middle as well we will cover this code path:
https://github.com/openjdk/jdk/pull/16895/files#diff-e3d6eea060882cab00827c00e1a83b0e0a5b2a31fa9a9aa2122841bbd57c4a6dL853

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16895#issuecomment-1885608696