RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]
Tejesh R
tr at openjdk.org
Tue Jan 16 05:58:45 UTC 2024
> The issue is that the doc area (in respect to the screen height which is 768px) which is at the bottom was causing the `JFileChooser `to be placed slightly above the set location. Was able to reproduce in local machine with reference to the failure image provided in the CI logs. The suggested fix is to place the main Frame slightly above the center of the screen than setting at the center of the screen. Several CI runs were made and no issue found.
Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
Review fix
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17364/files
- new: https://git.openjdk.org/jdk/pull/17364/files/e8dfd6b7..06188daa
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17364&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17364&range=02-03
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/17364.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17364/head:pull/17364
PR: https://git.openjdk.org/jdk/pull/17364
More information about the client-libs-dev
mailing list