RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]

Phil Race prr at openjdk.org
Thu Jan 18 22:57:27 UTC 2024


On Tue, 16 Jan 2024 05:58:45 GMT, Tejesh R <tr at openjdk.org> wrote:

>> The issue is that the doc area (in respect to the screen height which is 768px) which is at the bottom was causing the `JFileChooser `to be placed slightly above the set location. Was able to reproduce in local machine with reference to the failure image provided in the CI logs. The suggested fix is to place the main Frame slightly above the center of the screen than setting at the center of the screen. Several CI runs were made and no issue found.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

I suppose you can't know exactly how much space you need since the dialog size is out of your control.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17364#pullrequestreview-1830687939


More information about the client-libs-dev mailing list