RFR: 8320692: Null icon returned for .exe without custom icon

Thu Jan 18 00:56:19 UTC 2024

Replaced asserts with NullPointerException calls because outside of testing that would be more informative - i do not think many people running their applications with assertions in system libraries enabled;
Added a code that will analyze the result of the getIcon and will fall back to the default icon for the file type retrieved from the ShellFolder;
Added a test case made by Aleksei Ivanov.

-------------

Commit messages:
 - 8320692: Null icon returned for .exe without custom icon

Changes: https://git.openjdk.org/jdk/pull/17475/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17475&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8320692
  Stats: 286 lines in 2 files changed: 280 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/17475.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17475/head:pull/17475

PR: https://git.openjdk.org/jdk/pull/17475