RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v8]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jan 19 04:48:42 UTC 2024


On Thu, 18 Jan 2024 21:46:47 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Honour max/min size if set by user
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 800:
> 
>> 798:      * rigid along the other axis.
>> 799:      */
>> 800:     public Dimension getMaximumSize() {
> 
> Since we are here, you should fix this to add the @return. This does not need to be part of the CSR

Added @param and @return

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15325#discussion_r1458339631


More information about the client-libs-dev mailing list