RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v8]

Phil Race prr at openjdk.org
Fri Jan 19 18:06:31 UTC 2024


On Thu, 18 Jan 2024 21:46:39 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Honour max/min size if set by user
>
> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 784:
> 
>> 782:      * rigid along the other axis.
>> 783:      */
>> 784:     public Dimension getMinimumSize() {
> 
> Since we are here, you should fix this to add the @return. This does not need to be part of the CSR

I've changed my mind on not including these in the CSR based on what is written there - I think we should include it.
We wouldn't have needed to include a simple
"@return the minimum size"

but you do need the extra words somewhere so either way this method needs to be in the CSR

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15325#discussion_r1459462649


More information about the client-libs-dev mailing list