RFR: 8320692: Null icon returned for .exe without custom icon [v2]

[Sergey Bylokhov]

On Thu, 18 Jan 2024 19:40:40 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Replaced asserts with NullPointerException calls because outside of testing that would be more informative - i do not think many people running their applications with assertions in system libraries enabled;
>> Added a code that will analyze the result of the getIcon and will fall back to the default icon for the file type retrieved from the ShellFolder;
>> Added a test case made by Aleksei Ivanov.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert NPE to asserts
>   Move null check inside the loop so we do not retrieve extra
>   icons if we encounter a null one

test/jdk/javax/swing/JFileChooser/FileSystemView/NoIconExeNPE.java line 264:

> 262:             FileSystemView fsv = FileSystemView.getFileSystemView();
> 263:             // No NullPointerException is expected
> 264:             fsv.getSystemIcon(hello.toFile());

Maybe we should check that something useful is returned? at least non-null VS null value?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17475#discussion_r1461241572