RFR: 8320692: Null icon returned for .exe without custom icon [v2]

[Alexander Zuev]

On Fri, 19 Jan 2024 17:42:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert NPE to asserts
>>   Move null check inside the loop so we do not retrieve extra
>>   icons if we encounter a null one
>
> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 1421:
> 
>> 1419:         public MultiResolutionIconImage(int baseSize, Map<Integer, Image> resolutionVariants) {
>> 1420:             assert !resolutionVariants.containsValue(null)
>> 1421:                     : "There are null icons in the MRI variants map";
> 
> Here's an extra space. The colon aligned with `!` which starts the condition.
> 
> Could you please revert it too?

Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17475#discussion_r1462340795