RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Wed Jan 31 10:52:02 UTC 2024
On Wed, 31 Jan 2024 09:22:41 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Capitalized static final variables
>
> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 142:
>
>> 140: } catch (NullPointerException e) {
>> 141: g.drawString("caught expected NPE for null String, int", 20, 40);
>> 142: }/* catch (Exception e) {
>
> I guess u can remove these instead of commenting? Any reason for commenting these instead of removing?
These lines are commented in existing code. Felt it may be useful for further debugging in case of failure, so kept as it is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1472645679
More information about the client-libs-dev
mailing list