RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]
Tejesh R
tr at openjdk.org
Wed Jan 31 11:04:04 UTC 2024
On Wed, 31 Jan 2024 10:49:05 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:
>> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 142:
>>
>>> 140: } catch (NullPointerException e) {
>>> 141: g.drawString("caught expected NPE for null String, int", 20, 40);
>>> 142: }/* catch (Exception e) {
>>
>> I guess u can remove these instead of commenting? Any reason for commenting these instead of removing?
>
> These lines are commented in existing code. Felt it may be useful for further debugging in case of failure, so kept as it is.
Ok, else the fix is fine for me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1472660678
More information about the client-libs-dev
mailing list