RFR: 8314498: [macos] Transferring File objects to Finder fails [v2]
Phil Race
prr at openjdk.org
Fri Jul 12 17:33:52 UTC 2024
On Thu, 11 Jul 2024 21:16:24 GMT, Alexey Ushakov <avu at openjdk.org> wrote:
>> Here is an updated version of the fix we have used in Jetbrains Runtime for quite a while. It has been tested by running jdk_desktop tests and manually using a test case attached to this issue.
>> There is no reg test as I've not found a reliable way to verify file list content inside the system clipboard.
>
> Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8314498: [macos] Transferring File objects to Finder fails
>
> Removed unnecessary parameter
src/java.desktop/macosx/native/libawt_lwawt/awt/CClipboard.m line 200:
> 198: i = j + 1;
> 199: }
> 200: }
I want to be sure I understand the intent of the above code .. it seems to indicate that the data is an arbitrary number of null terminated file names, and this code supports transferring them as an array of file URLs.
Right ?
Any particular reason the initial array capacity is 2 ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20144#discussion_r1676238162
More information about the client-libs-dev
mailing list