RFR: 8314498: [macos] Transferring File objects to Finder fails [v2]

Alexey Ushakov avu at openjdk.org
Fri Jul 12 20:42:53 UTC 2024


On Fri, 12 Jul 2024 17:31:29 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8314498: [macos] Transferring File objects to Finder fails
>>   
>>   Removed unnecessary parameter
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CClipboard.m line 200:
> 
>> 198:             i = j + 1;
>> 199:         }
>> 200:     }
> 
> I want to be sure I understand the intent of the above code .. it seems to indicate that the data is an arbitrary number of null terminated file names, and this code supports transferring them as an array of file URLs.
> Right ? 
> Any particular reason the initial array capacity is 2 ?

Yes, that's right. Concerning the initial size, there is no particular reason to use constant 2 as an initial capacity. This factory method is used for convenience (to put NSMutableArray immediately into the autorelease pool).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20144#discussion_r1676439008


More information about the client-libs-dev mailing list