RFR: 4265389: JSplitPane does not support ComponentOrientation [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jul 22 09:31:55 UTC 2024


On Mon, 22 Jul 2024 08:52:27 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   whitespace removal
>
> test/jdk/javax/swing/JSplitPane/TestSplitPaneOrientationTest.java line 60:
> 
>> 58:                                                 new JButton("Left"), new JButton("Right"));
>> 59:                 jsp.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
>> 60:                 if (jsp.getRightComponent() instanceof JButton button) {
> 
> Can be enhanced to check for LTR and UNKNOWN component orientation along with RTL.

Could be but maynot be required for now...lot of existing test in JSplitPane that doesn't have orientation set so tests UNKNOWN orientation by default and since UNKNOWN=LTR so LTR also gets tested there..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20214#discussion_r1686256231


More information about the client-libs-dev mailing list