RFR: 4265389: JSplitPane does not support ComponentOrientation [v6]

Abhishek Kumar abhiscxk at openjdk.org
Mon Jul 22 08:55:34 UTC 2024


On Fri, 19 Jul 2024 08:05:06 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> JSplitPane's support of CompoentOrientation is not present so if orientation is RTL, it still renders left component on left and right component on right instead of other way around..
>> Fix to make it support RTL orientation
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   whitespace removal

test/jdk/javax/swing/JSplitPane/TestSplitPaneOrientationTest.java line 60:

> 58:                                                 new JButton("Left"), new JButton("Right"));
> 59:                 jsp.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
> 60:                 if (jsp.getRightComponent() instanceof JButton button) {

Can be enhanced to check for LTR and UNKNOWN component orientation along with RTL.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20214#discussion_r1686203708


More information about the client-libs-dev mailing list