RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v3]

Abhishek Kumar abhiscxk at openjdk.org
Wed Jul 24 06:03:31 UTC 2024


On Wed, 24 Jul 2024 05:53:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> "ColorChooser.showPreviewPanelText", Boolean.FALSE for GTKLookAndFeel because of which it is not applicable, in case we need to revisit this in future,

I guess it is better to add the comment in JBS in stead of the test. As a part of test history it can be referenced in future.
What do you say?

> although it does not make sense that preview panel is supported but not preview panel text, 

Yeah that was the trigger point for me to change the property as it doesn't make any sense to have a preview panel but not the title. 

> but let's maintain status-quo and not change product property just because of recently-modified internal test

seems fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1689183179


More information about the client-libs-dev mailing list