RFR: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Jul 24 06:11:33 UTC 2024
On Tue, 23 Jul 2024 11:08:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> This test was modified under [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the applet usage. Test modification includes the instruction change as well which says that `Check that there is a panel with "Text Preview Panel" text and with title "Preview" in the JColorChooser`. Applet test didn't say explicitly about the panel title.
>>
>> When the test is run with `GTKLookAndFeel` option, `Preview` title is missing due to the `showPreviewPanelText` property defined for `GTKLookAndFeel` is set to **FALSE**. `showPreviewPanelText` property is not defined for other L&Fs and that leads to fallback to the default value of **TRUE** for the property while lookup.
>>
>> Proposed fix is to change the default value of `showPreviewPanelText` property to **TRUE** for GTK L&F.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> removed bug id from jtreg tag
JBS will not be read normally after this is fixed, so in future when the test is run and there's a doubt why this was done, this comment will future-proof the reason, and if we do change the property in future for some product related issue then we can modify this test accordingly..
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20104#issuecomment-2246979807
More information about the client-libs-dev
mailing list