RFR: 8185429: [macos] After the dialog is closed, there is no window become active [v2]

Damon Nguyen dnguyen at openjdk.org
Thu Jun 13 06:25:14 UTC 2024


On Fri, 7 Jun 2024 20:34:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Add a check for previous focused window on modal unblocking. If the owner of a closing dialog was the last focused window, then the owner of the dialog should regain focus.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use == over .equals

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 1065:

> 1063:             requestWindowFocus();
> 1064:         }
> 1065:         checkBlockingAndOrder();

Just checking, is it critical for this check to be after the execute()? Looks like we can have the if(blocked) {}, else if (target == currFocus) {} setup instead if it doesn't matter.

Also, since it's been mentioned in previous PRs, maybe it's worth fixing the grammar in this PR and on the issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19588#discussion_r1637584399


More information about the client-libs-dev mailing list