RFR: 8185429: [macos] After the dialog is closed, there is no window become active [v2]

[Alisen Chung]

On Thu, 13 Jun 2024 05:48:22 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use == over .equals
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 1065:
> 
>> 1063:             requestWindowFocus();
>> 1064:         }
>> 1065:         checkBlockingAndOrder();
> 
> Just checking, is it critical for this check to be after the execute()? Looks like we can have the if(blocked) {}, else if (target == currFocus) {} setup instead if it doesn't matter.
> 
> Also, since it's been mentioned in previous PRs, maybe it's worth fixing the grammar in this PR and on the issue.

You can't focus a blocked window, so it has to be in this order

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19588#discussion_r1638422014