RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

[Abhishek Kumar]

On Tue, 18 Jun 2024 12:50:42 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java line 1056:
>> 
>>> 1054:      * @param hide true if mnemonics should be hidden
>>> 1055:      * @since 23
>>> 1056:      */
>> 
>> Hmm. So .. new public API ? Is this absolutely necessary ? 
>> I don't see why an app would need to call this directly. 
>> And it would need a CSR, and it is too late for 23 anyway.
>
>> Hmm. So .. new public API ? Is this absolutely necessary ?
> I don't see why an app would need to call this directly.
> 
> `setMnemonicHidden` can be changed to a `protected` member as you pointed out it may not be required by an app to call this method.
> But I guess the `isMnemonicHidden` should be public API.
> 
>> And it would need a CSR, and it is too late for 23 anyway.
> 
> Will update the `@since to 24` for `isMnemonicHidden` method if we are ok with `isMnemonicHidden` method's access modifier.

Infact `isMnemonicHidden` can also be changed to a `protected` member of the class. I will check and update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1644448223