RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

Phil Race prr at openjdk.org
Thu Jun 20 20:58:12 UTC 2024


On Tue, 18 Jun 2024 13:15:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>> Hmm. So .. new public API ? Is this absolutely necessary ?
>> I don't see why an app would need to call this directly.
>> 
>> `setMnemonicHidden` can be changed to a `protected` member as you pointed out it may not be required by an app to call this method.
>> But I guess the `isMnemonicHidden` should be public API.
>> 
>>> And it would need a CSR, and it is too late for 23 anyway.
>> 
>> Will update the `@since to 24` for `isMnemonicHidden` method if we are ok with `isMnemonicHidden` method's access modifier.
>
> Infact `isMnemonicHidden` can also be changed to a `protected` member of the class. I will check and update.

protected members of public classes are part of the API
Go look at javadoc - or generate javadoc for this change and see for yourself. So this still requires a CSR as written.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1648120126


More information about the client-libs-dev mailing list