RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
Alexey Ivanov
aivanov at openjdk.org
Wed Jun 19 19:23:09 UTC 2024
On Wed, 19 Jun 2024 15:38:10 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>>> How does it help? You're delaying EDT.
>>
>> I was unable to reproduce the failure scenario in my local machine but didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as they are able to replicate the failure.
>
>> You should rather call [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) to add the delay between method calls.
>
> this change does exactly that, it calls `SwingTestHelper#setDelay` since `bug6492108 extends SwingTestHelper`
>
>> You should ask Vitaly to test your changeset in his environment to confirm the failure is gone.
>
> I am able to reproduce the issue locally on Ubuntu 22.04, and the provided fix works fine for me.
>
> I assume @vprovodin has already done this testing, since he was the one who provided the solution in the JBS issue description.
My bad, I read it as if it were `delay(50)`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1646618947
More information about the client-libs-dev
mailing list