RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4

Alexey Ivanov aivanov at openjdk.org
Wed Jun 19 19:38:08 UTC 2024


On Wed, 19 Jun 2024 19:20:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> You should rather call [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) to add the delay between method calls.
>> 
>> this change does exactly that, it calls `SwingTestHelper#setDelay` since `bug6492108 extends SwingTestHelper`
>> 
>>> You should ask Vitaly to test your changeset in his environment to confirm the failure is gone.
>> 
>> I am able to reproduce the issue locally on Ubuntu 22.04, and the provided fix works fine for me.
>> 
>> I assume @vprovodin has already done this testing, since he was the one who provided the solution in the JBS issue description.
>
> My bad, I read it as if it were `delay(50)`.

Would it be clearer if `setDelay(50)` was called in the constructor of `bug6492108`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1646628379


More information about the client-libs-dev mailing list