RFR: 8334509: Cancelling PageDialog does not return the same PageFormat object [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jun 21 03:20:15 UTC 2024


On Thu, 20 Jun 2024 20:04:47 GMT, Phil Race <prr at openjdk.org> wrote:

>> The only problem with the flag is that the data flow is not as clear.
>> 
>> I'm not insisting, it worked before and it will work in the future.
>
> The way it was "before" is that we always returned the value of "doIt". Why not restore that for consistency ?

I believe that's what this PR is doing, it returns value of "doIt" at end, isn't it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19786#discussion_r1648364406


More information about the client-libs-dev mailing list