RFR: 8334509: Cancelling PageDialog does not return the same PageFormat object [v2]

[Alexey Ivanov]

On Fri, 21 Jun 2024 03:17:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The way it was "before" is that we always returned the value of "doIt". Why not restore that for consistency ?
>
> I believe that's what this PR is doing, it returns value of "doIt" at end, isn't it?

> The way it was "before" is that we always returned the value of "doIt". Why not restore that for consistency ?

I think it's clearer with explicit `JNI_FALSE` even though it's inconsistent. You don't have to track in your mind what value `doIt` has.

> I believe that's what this PR is doing, it returns value of "doIt" at end, isn't it?

Yes, it does *now*. You changed it after Phil had left his comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19786#discussion_r1649205235