RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v3]

Kevin Rushforth kcr at openjdk.org
Mon Jun 24 12:47:12 UTC 2024


On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The no-arg constructor BasicSliderUI() was added under [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added why

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line 154:

> 152:      * Constructs a {@code BasicSliderUI}.
> 153:      * @deprecated This constructor was exposed erroneously and will be removed in next version.
> 154:      *             Use {@link #BasicSliderUI(JSlider b)} instead.

Did you build the docs and check that the `@link` command works? I would have expected it without the named parameter: `{@link #BasicSliderUI(JSlider)}`.

Also, you might want to change "next version" to "a future version" to allow more flexibility as to the timing of the removal.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1650968421


More information about the client-libs-dev mailing list