RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v3]

[Alexey Ivanov]

On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The no-arg constructor BasicSliderUI() was added under [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added why

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line 154:

> 152:      * Constructs a {@code BasicSliderUI}.
> 153:      * @deprecated This constructor was exposed erroneously and will be removed in next version.
> 154:      *             Use {@link #BasicSliderUI(JSlider b)} instead.

Suggestion:

     * @deprecated This constructor was exposed erroneously and will be removed in a future release.
     *             Use {@link #BasicSliderUI(JSlider)} instead.


I agree, _“in a future release”_ or _“version”_ would be more accurate.

I verified that it builds with the parameter name, however, it's more common to omit parameter names.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2135839371
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1651053840